Compiler flag support for SQLite.swift and Android#59
Compiler flag support for SQLite.swift and Android#59marcprux wants to merge 4 commits intosbooth:mainfrom
Conversation
|
Thanks for this PR. Android support would be a nice addition. Many of those flag changes are not ones I'm keen to make. I understand the rationale but I am hesitant to deviate from the official SQLite recommendations without good reason for each change. Maybe SQLite.swift could adapt to the features available in the SQLite library it's using? |
I can look into this, but some of the options like SQLITE_THREADSAFE=0 would be non-starters.:
I can look into debugging the issue with the other options, but if |
|
I imagine that Could you split this PR in two parts, one for Android support and one for SQLite.swift support, so I can more easily review what support for each entails? |
|
I think the bulk of this is obsoleted by #65 |
This PR adds the necessary compile flags to work as a custom SQLite build for https://github.com/stephencelis/SQLite.swift, as well as adding support for building and testing on Android.
Prior to this fix, attempting to run the SQLite.swift tests on macOS or Android would crash at: