Merged
Conversation
It causes errors in most builds, for a variety of reasons.
Revert including util in the bindings.
Member
Author
|
Unrelatedly, 'yum' stopped working on the quay build, because it's looking for the mirror URLs: but there's no (or no longer?) any 'c/' subdirectory; it's actually just available at: |
Member
Author
|
Yum works again; builds now succeeding once more. |
Member
|
that works for me ... though we should not have the changes to libsbml.i / libsbml.h here. After that i think it is good to merge. |
Member
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the 'rapid build' github action to use c++26 when possible. This should allow us to catch any changes (dropped constructs, etc.) sooner rather than later.
Worked out of the box, so no problems as of now.