Merged
Conversation
skeating
approved these changes
Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit changes the auto test runner to include tests from sub directories, rather than just test. While previous javac versions compiled the old version without issue, newer javac compilers raise an issue. it was originally submitted by @pgrt
Motivation and Context
The change is needed, to get the java bindings built with newer javac, as it otherwise will fail when compiling the tests.
the change still works for older javac versions as well.
fixes #281
Types of changes
Checklist:
Testing
this will be tested on a run of the extensive checks.