Update autotools config for better platform detection#273
Merged
fbergmann merged 1 commit intosbmlteam:developmentfrom Sep 29, 2022
Merged
Update autotools config for better platform detection#273fbergmann merged 1 commit intosbmlteam:developmentfrom
fbergmann merged 1 commit intosbmlteam:developmentfrom
Conversation
fbergmann
approved these changes
Sep 29, 2022
Member
fbergmann
left a comment
There was a problem hiding this comment.
thank you for the submission.
Note however, that we are in the process of phasing out the autotools build. Several configuration options such as support for SBML packages (supported by the cmake build) are not available with the makefiles. So we recommend using the cmake build.
Member
|
I'll skip the CI step, as we dont have any scripts testing the gnumake build. |
Contributor
Author
|
That's good to hear. I now see the section on CMake in the website, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change updates the platform detection for autotools, as hinted by the failure itself:
Motivation and Context
On an aarch64 Linux machine, running
./configureshows the error in the previous section.I guess aarch64 isn't really a thing back in 2008.
Types of changes
Checklist:
Testing
I've tested the change on both x86_64 and aarch64, the build completed correctly with the change.