Skip to content

Cmake libxml fix#250

Merged
fbergmann merged 2 commits intodevelopmentfrom
cmake-libxml-fix
Jul 15, 2022
Merged

Cmake libxml fix#250
fbergmann merged 2 commits intodevelopmentfrom
cmake-libxml-fix

Conversation

@fbergmann
Copy link
Copy Markdown
Member

Description

This fixes the 2nd issue that alan came across, where the compile tests for libxml2 would fail for a static library, because of missing math symbols.

Motivation and Context

fixes #240

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@fbergmann fbergmann merged commit 6a512ff into development Jul 15, 2022
@fbergmann fbergmann deleted the cmake-libxml-fix branch July 15, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't build with MSVC 2019 and C++17 support?

1 participant