Fix signature of SBase_getNumPlugins in prototype#237
Merged
fbergmann merged 1 commit intosbmlteam:developmentfrom Jun 22, 2022
Merged
Fix signature of SBase_getNumPlugins in prototype#237fbergmann merged 1 commit intosbmlteam:developmentfrom
SBase_getNumPlugins in prototype#237fbergmann merged 1 commit intosbmlteam:developmentfrom
Conversation
This was different from signature in implementation, leading to the implementation not being C-exported correctly, and having C++ name mangling: ```console % nm libsbml.so | grep SBase_getNumPlugins 00000000008f5240 T _Z19SBase_getNumPluginsPK5SBase ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was different from signature in implementation, leading to the
implementation not being C-exported correctly, and having C++ name mangling:
Similar to #189. Spotted in JuliaPackaging/Yggdrasil#5059.
Description
Motivation and Context
Types of changes
Checklist:
Testing