User lowercase name for Windows library#225
Merged
fbergmann merged 1 commit intosbmlteam:developmentfrom May 3, 2022
Merged
Conversation
Most Windows on users would have a case-insensitive filesystem, but the case is relevant when compiling on a case-sensitive filesystem, which is usually the case when cross-compiling with MinGW on Linux, and MinGW consistently uses lowercase names for libraries and header files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Most Windows on users would have a case-insensitive filesystem, but the case is
relevant when compiling on a case-sensitive filesystem, which is usually the
case when cross-compiling with MinGW on Linux, and MinGW consistently uses
lowercase names for libraries and header files.
Motivation and Context
The change is required to be able to compile the library for Windows on a case-sensitive filesystem.
Types of changes
Checklist:
Testing