Skip to content

Ensure Translate/OutputSBML work on Octave and Matlab#175

Merged
skeating merged 53 commits intodevelopmentfrom
matlab-octave-fun
Jun 22, 2022
Merged

Ensure Translate/OutputSBML work on Octave and Matlab#175
skeating merged 53 commits intodevelopmentfrom
matlab-octave-fun

Conversation

@fbergmann
Copy link
Copy Markdown
Member

Description

We need to do a couple of things here:

  • cleanup use of global variables to sort leaking crash in octave
  • cleanup m files (for example 0/0 will give a warning each time in octave, maybe better to use NaN)
  • add a basic octave ci test for linux.

Motivation and Context

Currently the octave bindings are broken.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@skeating skeating marked this pull request as ready for review May 6, 2022 16:01
@skeating skeating self-requested a review June 22, 2022 14:15
@skeating skeating merged commit 3fb6298 into development Jun 22, 2022
@skeating skeating deleted the matlab-octave-fun branch June 22, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants