Conversation
|
And we need to decide what to do about |
|
Forget about scheme, what about deleting |
|
Ok, I dropped About Interestingly, since And I'd keep |
I didn't mean "drop scheme". I meant that the metadata_directory argument has been ignored by build backends in practice, so why keep it here? |
Ah sorry, I misinterpreted what you meant with "forget about scheme".
For symmetry and easier implementation by frontends. I'd say if metadata_directory turns out to be useless in practice, that should be clarified in an amendment to PEP 517 that addresses both variants of build_wheel. |
|
This argument could go in circles. It's already asymmetrical because there isn't a |
|
Ok, lets drop metadata_directory and see what people say. |
|
We could also say that frontends must not call prepare_metadata_for_build_wheel in case of editables, and rely only on the metadata produced by build_wheel_for_editable in such case. Not sure. |
|
Are you supposed to install the requirements before build or are we doing those in pyproject.toml these days? We would do the same steps here. The mechanism for making sure the metadata is (mostly) the same is to have deterministic metadata generation, not to copy it from a 📂 |
|
@dholth sorry I don't understand your last comment. |
|
Nothing changes by removing the metadata directory argument. It only means we have to do what backends do anyway, which is to regenerate the metadata. I suppose there will be details about exactly when dependencies are installed, lack of build isolation etc. |
|
Ok, perhaps I overthink this. So if this is in good shape for you, I guess the next step is to summon @pfmoore ;) Paul, as sponsor, would you like to have a look and tell us if this seems good enough to open a draft PEP or if you see some changes to do before that ? |
e69ce33 to
f57d22c
Compare
3cf3e1b to
11f5323
Compare
|
@dholth I added 3 commits. Please let me know what you think. If ok for you I think this is ready to go for public discussion. |
11f5323 to
2b0a164
Compare
|
For example if we don't provide a separate build editables dependency hook then those dependencies can't differ... |
|
Yeah but I think this is not the place nor the time to question the philosophy of pep 517. If In the case of |
|
Sounds good. Got requirements and metadata confused. We should ask the pep517 authors.
…On Sun, Apr 25, 2021, at 1:27 PM, Stéphane Bidoul wrote:
Yeah but I think this is not the place nor the time to question the philosophy of pep 517. If `get_requires_for_build_*` is in the spec, there must be use cases for it, and it makes sens to have a third one for editables.
In the case of `prepare_metadata_for_build_*` I am now convinced it is different because, as an optimization to help the resolver, it is not necessary, since the frontend knows beforehand that the editable will have to be installed, so there is no need to prepare discardable metadata.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABSZEXWOJ7FK4HAARIZCLTTKRGHPANCNFSM42JD4HJA>.
|
|
Ok thanks. I'll post it soon. Let's see if this thing flies. |
7d0488d to
f0927bc
Compare
13cb33d to
7ffadee
Compare
No description provided.