fix/py-phylo2vec: rust binding call in to_edges#31
Merged
Neclow merged 4 commits intosbhattlab:mainfrom May 14, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug by updating the Rust binding call within the to_edges conversion function and includes additional test cases to verify the vector conversions via edges and ancestry. Key changes include:
- Updating test names and adding new tests in test_base.py for verifying vector conversion consistency.
- Changing the function call in to_edges from core.to_edges to core.get_edges and updating its type signature in edges.py.
- Bumping version numbers and updating project metadata in Cargo.toml and pixi.toml.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| py-phylo2vec/tests/test_base.py | Renamed tests for clarity and added new edge/ancestry validation tests. |
| py-phylo2vec/phylo2vec/base/edges.py | Updated type signatures and corrected rust binding function call. |
| py-phylo2vec/Cargo.toml | Updated project version from 1.1.0 to 1.1.1 |
| pixi.toml | Updated version and author metadata for consistency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix to be pushed to a 1.1.1 patch release