feat: add conversion from v to edge list#25
Merged
Neclow merged 3 commits intosbhattlab:mainfrom May 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for converting between phylo2vec vectors and edge lists by introducing new functions in both Rust and Python.
- New Rust functions get_edges and from_edges are implemented in the core ops module.
- Python wrappers and integration in init.py have been added for the new functionality.
- Additional tests have been added in the Rust module to verify the edge list conversion.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| py-phylo2vec/src/lib.rs | Added Python-exposed functions get_edges and from_edges |
| py-phylo2vec/phylo2vec/base/edges.py | Introduced Python conversion methods from_edges and to_edges |
| py-phylo2vec/phylo2vec/init.py | Updated module exports to include new edge conversion functions |
| phylo2vec/src/tree_vec/ops/vector.rs | Added get_edges_from_pairs, get_edges, and from_edges functions |
| phylo2vec/src/tree_vec/ops/mod.rs | Integrated new functions into the ops module and added tests |
| phylo2vec/src/tree_vec/mod.rs | Added method get_edges on TreeVec and new tests for edge conversion |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.