Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the code to address clippy warnings by modernizing syntax, removing redundant returns, and using slices where appropriate. Key changes include updating function signatures to use slice references, streamlining for loops and return statements, and standardizing type aliases across the codebase.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| r-phylo2vec/src/rust/src/lib.rs | Simplifies conversions and return expressions. |
| py-phylo2vec/src/lib.rs | Eliminates redundant variable assignments in function returns. |
| phylo2vec/src/utils.rs | Streamlines vector construction and loop iteration. |
| phylo2vec/src/tree_vec/{types.rs,ops/*,mod.rs} | Modernizes slice usage, refactors for loops, and standardizes naming. |
| phylo2vec/benches/benchmarks/core.rs | Updates benchmark calls with the latest API functions. |
Comments suppressed due to low confidence (1)
phylo2vec/src/tree_vec/ops/mod.rs:62
- Remove the debug print statement to avoid unintended output in production builds.
println!("{:?}", ancestry_add);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.