[BUG] ArrayIndexOutOfBoundsException for inconsistent detector index behavior (opensearch-project#843)

goyamegh · web-flow · commit 0ef8543b6096 · 2024-02-14T11:57:07.000-08:00
* Catch ArrayIndexOutOfBoundsException when detector is missing

Signed-off-by: Megha Goyal &lt;goyamegh@amazon.com&gt;

* Add a check on SearchHits.getHits() length

Signed-off-by: Megha Goyal &lt;goyamegh@amazon.com&gt;

* Remove index out of bounds exception

Signed-off-by: Megha Goyal &lt;goyamegh@amazon.com&gt;

---------

Signed-off-by: Megha Goyal &lt;goyamegh@amazon.com&gt;
diff --git a/src/main/java/org/opensearch/securityanalytics/transport/TransportCorrelateFindingAction.java b/src/main/java/org/opensearch/securityanalytics/transport/TransportCorrelateFindingAction.java
@@ -261,7 +261,8 @@ public void onResponse(SearchResponse response) {
                         }
 
                         SearchHits hits = response.getHits();
-                        if (hits.getTotalHits().value == 1) {
+                        // Detectors Index hits count could be more even if we fetch one
+                        if (hits.getTotalHits().value >= 1 && hits.getHits().length > 0) {
                             try {
                                 SearchHit hit = hits.getAt(0);
 
@@ -272,6 +273,7 @@ public void onResponse(SearchResponse response) {
                                 Detector detector = Detector.docParse(xcp, hit.getId(), hit.getVersion());
                                 joinEngine.onSearchDetectorResponse(detector, finding);
                             } catch (IOException e) {
+                                log.error("IOException for request {}", searchRequest.toString(), e);
                                 onFailures(e);
                             }
                         } else {
