Merged
Conversation
Choraden
reviewed
Dec 6, 2024
Choraden
reviewed
Dec 6, 2024
Choraden
reviewed
Dec 6, 2024
net.go
Outdated
Comment on lines
+72
to
+84
| Retry: 3, | ||
| RetryBackoff: 1 * time.Second, | ||
| } |
Contributor
There was a problem hiding this comment.
This does not belong here.
Add retry config and implementation in Dialer. Also, add test harness for dialing errors.
net.go:186:2: for loop can be changed to use an integer range (Go 1.22+) (intrange)
for i := 0; i < attempts; i++ {
--http-dial-attempts <int> (default 3) (env FORWARDER_HTTP_DIAL_ATTEMPTS)
The number of attempts to dial the network address.
--http-dial-backoff <duration> (default 1s) (env FORWARDER_HTTP_DIAL_BACKOFF)
The amount of time to wait between dial attempts.
78507b1 to
23190db
Compare
Choraden
approved these changes
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #706