Merged
Conversation
0c731d2 to
7a795db
Compare
Choraden
reviewed
Nov 7, 2024
Comment on lines
+533
to
+544
| g.Go(func() error { | ||
| return srv.Serve(l) | ||
| }) |
Contributor
There was a problem hiding this comment.
^C2024/11/07 14:41:01.894475 [proxy] [INFO] closing down proxy
2024/11/07 14:41:01.894515 [proxy] [INFO] waiting for connections to close
2024/11/07 14:41:01.894522 [proxy] [INFO] all connections closed
2024/11/07 14:41:01.894584 [ERROR] fatal error exiting: http: Server closed
exit status 1
Closing a proxy in a handler mode results in a fatal error.
Choraden
reviewed
Nov 7, 2024
Contributor
|
LGTM, personally I would go with a wrapper over a list of listeners that returns any accepted connection from the underlying slice, but this is even better! Left a proposition on adding "named" listeners. |
Contributor
Author
|
MultiListener is complicated its main disadvantage is that you accept a connection and then send it to worker. It's not guaranteed there is a worker available. It could be done but the standard interfaces are not well suited for that. |
7a795db to
d3d3289
Compare
Contributor
Author
|
@Choraden PTAL |
d3d3289 to
c967c5a
Compare
Add HTTPProxyConfig.ExtraListeners and refactor code to work with multiple listeners.
c967c5a to
e0da9aa
Compare
Contributor
Author
|
Squashed some commits and rebased. |
Choraden
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add HTTPProxyConfig.ExtraListeners and refactor code to work with multiple listeners.