Conversation
mmatczuk
commented
Oct 30, 2024
| @@ -1,26 +1,23 @@ | |||
| // Copyright 2022-2024 Sauce Labs Inc., all rights reserved. | |||
| // | |||
| // Copyright 2015 Google Inc. All rights reserved. | |||
Contributor
Author
There was a problem hiding this comment.
This is not Google's code.
Choraden
reviewed
Oct 31, 2024
Comment on lines
+1
to
+6
| # HELP test_dialer_closed_total Number of closed connections | ||
| # TYPE test_dialer_closed_total counter | ||
| test_dialer_closed_total{host="localhost"} 10 | ||
| # HELP test_dialer_dialed_total Number of dialed connections | ||
| # TYPE test_dialer_dialed_total counter | ||
| test_dialer_dialed_total{host="localhost"} 10 |
Contributor
There was a problem hiding this comment.
nit: Golden files of TestDialerMetrics traffic and default are identical. This does not really tests if returned connection tracks traffic.
Choraden
reviewed
Oct 31, 2024
utils/reflectx/reflectx_test.go
Outdated
| // file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
|
|
||
| package martian | ||
| package reflectx_test |
Contributor
There was a problem hiding this comment.
Is a separate test package intentional? I don't recall us using this practice.
Contributor
Author
There was a problem hiding this comment.
Moved tests to reflectx package
Contributor
|
LGTM, left minor comments. |
Make interface generic.
Add reflection hacks navigate the dynamically generated structures.
1cc101f to
d5c6f35
Compare
Contributor
Author
|
@Choraden PTAL |
d5c6f35 to
89f01f1
Compare
89f01f1 to
872ef26
Compare
Choraden
approved these changes
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.