Skip to content

conntrack: add connection tracker wrapper based on connfu#943

Merged
mmatczuk merged 6 commits intomainfrom
mmt/tracking_v2
Oct 28, 2024
Merged

conntrack: add connection tracker wrapper based on connfu#943
mmatczuk merged 6 commits intomainfrom
mmt/tracking_v2

Conversation

@mmatczuk
Copy link
Contributor

@mmatczuk mmatczuk commented Oct 16, 2024

Use builder pattern to return implementation with only required features. Use connfu to handle CloseWrite() and ReadFrom() propagation.

@mmatczuk mmatczuk requested a review from Choraden as a code owner October 16, 2024 10:09
@mmatczuk mmatczuk force-pushed the mmt/tracking_v2 branch 4 times, most recently from eab9d95 to 99b37c7 Compare October 16, 2024 10:39
Choraden
Choraden reviewed Oct 16, 2024
View reviewed changes
Choraden
Choraden reviewed Oct 16, 2024
View reviewed changes
Choraden
Choraden reviewed Oct 16, 2024
View reviewed changes
@Choraden
Copy link
Contributor

Choraden commented Oct 16, 2024 •
edited
Loading

Although tracked seems cool, we could use some fancy name to emphasise it's a real net.Conn on steroids.
Some proposals:

  • connx
  • turboconn
  • hyperconn
  • connboost

@mmatczuk
Copy link
Contributor Author

mmatczuk commented Oct 16, 2024

Traditionally the name is conntrac not to get confused with conntrac in Linux.

@mmatczuk
Copy link
Contributor Author

mmatczuk commented Oct 16, 2024

Renamed package to conntrack, added Build() and BuildWithObserver() to simplify usage.

@mmatczuk mmatczuk changed the title tracked: add connection tracker wrapper based on connfu conntrack: add connection tracker wrapper based on connfu Oct 16, 2024
@mmatczuk
conntrack: add connection tracker wrapper based on connfu
5995f42 
Use builder pattern to return implementation with only required features.
Use connfu to handle CloseWrite() and ReadFrom() propagation.
@mmatczuk
conntrack: add Observer() for accessing observer retroactively
eaf9863
@mmatczuk
net: use conntrack pkg instead of TrackedConn
ee0d550
@mmatczuk mmatczuk force-pushed the mmt/tracking_v2 branch 2 times, most recently from c9ae8e3 to e20c8ac Compare October 16, 2024 14:30
@Choraden
Copy link
Contributor

Choraden commented Oct 17, 2024

@mmatczuk This looks good!

  1. I wonder if we want to add assertion in martian that the splice optimisation is to take place.
  2. I would love to see some numbers on how it improves performance.

@mmatczuk mmatczuk merged commit 8544324 into main Oct 28, 2024
@mmatczuk mmatczuk deleted the mmt/tracking_v2 branch October 28, 2024 15:06
@mmatczuk mmatczuk mentioned this pull request Nov 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Choraden Choraden Choraden left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmatczuk @Choraden