chore: simplify generating metrics docs #810
Merged
Conversation
Choraden
reviewed
May 22, 2024
command/run/run.go
Outdated
| cmd.SetErr(io.Discard) | ||
|
|
||
| var stdout *os.File | ||
| stdout, os.Stdout = os.Stdout, os.NewFile(10, os.DevNull) |
Contributor
There was a problem hiding this comment.
What does the '10' stand for here?
Choraden
approved these changes
May 22, 2024
The descMetrics flag is changed to unbound dryRun field that performs a regular dry-run. Internal command creation is extracted to method. Metrics() function is added, this avoids encoding json data to stdout.
Remove json encoding and decoding.
Contributor
Author
|
Refactored that to log config |
c57fcc2 to
17ec238
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.