Skip to content

bind: change data URI scheme format in pac flag usage#744

Merged
mmatczuk merged 1 commit intomainfrom
hg/escape_pac
Mar 13, 2024
Merged

bind: change data URI scheme format in pac flag usage#744
mmatczuk merged 1 commit intomainfrom
hg/escape_pac

Conversation

@Choraden
Copy link
Contributor

@Choraden Choraden commented Mar 12, 2024

'<' and '>' make a mess in sc docs.

-p, --pac <path or URL> (env FORWARDER_PAC)
    Proxy Auto-Configuration file to use for upstream proxy selection. It can be a local file or a URL, you can
    also use '-' to read from stdin. The data URI scheme is supported, the format is "data:base64,encoded_data".

@Choraden
Copy link
Contributor Author

Choraden commented Mar 12, 2024 •
edited
Loading

Looks like it also wasn't working in forwarder's docs, https://forwarder-proxy.io/cli/forwarder_run/#pac:
Screenshot 2024-03-12 at 20 18 50

@mmatczuk
Copy link
Contributor

mmatczuk commented Mar 13, 2024

So escape it.

@Choraden
bind: escape pac flag format in usage
9837a90 
Notice we also escape format in the first line '<path or URL>' as the first pair of backticks('`') is stripped in flag.UnquoteUsage(*flag.Flag).
@Choraden
Copy link
Contributor Author

Choraden commented Mar 13, 2024

Escaped it. Notice, we also escape format in the first line '' as the first pair of backticks('`') is stripped in flag.UnquoteUsage(*flag.Flag).

@mmatczuk mmatczuk merged commit bb4fb24 into main Mar 13, 2024
@mmatczuk mmatczuk deleted the hg/escape_pac branch March 13, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Choraden @mmatczuk