Merged
Conversation
This is a temporary solution until we have context-aware logging everywhere. It allows us to log the network and address of the connection being established together with the trace ID.
alexh-sauce
approved these changes
Feb 28, 2024
2024/02/28 14:55:23.447579 [proxy] [DEBUG] closing connection from 127.0.0.1:54332 duration=1.982912042s 2024/02/28 14:56:10.294136 [proxy] [DEBUG] accepted connection from 127.0.0.1:54337 2024/02/28 14:56:10.294249 [proxy] [DEBUG] [2-4c948b90] read CONNECT request host=google.com:443 2024/02/28 14:56:10.294267 [proxy] [DEBUG] [2-4c948b90] CONNECT to host directly: google.com:443 2024/02/28 14:56:10.294271 [proxy] [DEBUG] [2-4c948b90] opening connection to tcp google.com:443 2024/02/28 14:56:10.353445 [proxy] [DEBUG] [2-4c948b90] connection to tcp google.com:443 established duration=59.166ms Fixes #645
06505ee to
5ad77f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #645