Conversation
Choraden
reviewed
Feb 23, 2024
A regression was introduced in 9cc9854 that allowed use of HTTP/2 inside MITM. This patch adds the following to all http.Transport instances t.TLSNextProto = make(map[string]func(string, *tls.Conn) http.RoundTripper) Interestingly with that t = t.Clone() we get an error forwarder encountered an unexpected error net/http: HTTP/1.x transport connection broken: malformed HTTP response "\x00\x00\x12\x04\x00\x00\x00\x00\x00\x00\x03\x00\x00\x00\x80\x00\x04\x00\x01\x00\x00\x00\x05\x00\xff\xff\xff\x00\x00\x04\b\x00\x00\x00\x00\x00\x7f\xff\x00\x00\x00\x00\b\a\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x01"
7cd1d4d to
445a896
Compare
Choraden
approved these changes
Feb 23, 2024
Contributor
Choraden
left a comment
There was a problem hiding this comment.
Good catch. I wouldn't expect Clone to do such a nasty thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression was introduced in 9cc9854 that allowed use of HTTP/2 inside MITM.
This patch adds the following to all http.Transport instances
Interestingly with that t = t.Clone() we get an error