net(metrics): rename unspecified host to localhost#711
Merged
Conversation
mmatczuk
reviewed
Feb 22, 2024
net_metrics.go
Outdated
| return "unknown" | ||
| } | ||
|
|
||
| if host == "0.0.0.0" || host == "::" { |
Contributor
There was a problem hiding this comment.
Let's refactor and use isLocalhost(req *http.Request) bool from HTTPProxy
f30905b to
9802431
Compare
The nopResolver would not ever dial. The idea had some potential however, it would allocate lots of memory. This happend as the resolver didn't know the dial function was nop. It was allocating memory for new DNS requests that would never be sent. This patch utilizes lookupStaticHost[1] - an internal function from net package. The function watches /etc/hosts file and looks up hosts there. Fixes #628 [1] https://github.com/golang/go/blob/master/src/net/hosts.go#L129
9802431 to
819b429
Compare
Contributor
|
Love it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.