Merged
Conversation
Improve handleLoop() debug logs and log connection duration.
0cae526 to
6f1e38f
Compare
Choraden
reviewed
Feb 16, 2024
Comment on lines
170
to
181
| func (l *Listener) Addr() net.Addr { | ||
| if l.listener == nil { | ||
| return nil | ||
| } | ||
| return l.listener.Addr() | ||
| } | ||
|
|
||
| func (l *Listener) Close() error { | ||
| if l.listener == nil { | ||
| return nil | ||
| } | ||
|
|
||
| return l.listener.Close() |
Contributor
There was a problem hiding this comment.
Addr() has no space between if and return when Close() has. Please unify it.
Choraden
reviewed
Feb 16, 2024
http_proxy.go
Outdated
| transport: rt, | ||
| log: log, | ||
| metrics: newMetrics(cfg.PromRegistry, cfg.PromNamespace), | ||
| metrics: newHTTPProxyMetricsMetrics(cfg.PromRegistry, cfg.PromNamespace), |
Contributor
|
LGTM |
Replace callbacks with Prometheus registry and record metrics.
6f1e38f to
72e0e4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.