chore(martian): unpack Proxy to proxyConn and move stuff around#673
Merged
chore(martian): unpack Proxy to proxyConn and move stuff around#673
Conversation
Choraden
approved these changes
Feb 5, 2024
Contributor
Choraden
left a comment
There was a problem hiding this comment.
LGTM
I guess the new files can have 2024 copyright note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add
proxyConntype to avoid passing conn and buffer as function arguments.In addition to that move different items from proxy.go to dedicated files.