Don't require format to be exhaustive#34
Merged
satyrius merged 1 commit intosatyrius:masterfrom Feb 27, 2017
haswalt:feature/broad-match
Merged
Don't require format to be exhaustive#34satyrius merged 1 commit intosatyrius:masterfrom haswalt:feature/broad-match
satyrius merged 1 commit intosatyrius:masterfrom
haswalt:feature/broad-match
Conversation
Owner
|
It looks reasonable, no need to force RE to metch the end of the line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently supplying a log format requires it to be exhaustive, match until end of line.
I want to be able to match partial log entries, this was if (in my use case there is) additional data in the log line that i don't care about there is no need to parse it out.