Fixed issue with database upgrade when MultiDex support is enabled.#434
Merged
sibelius merged 1 commit intochennaione:masterfrom Nov 23, 2015
Merged
Fixed issue with database upgrade when MultiDex support is enabled.#434sibelius merged 1 commit intochennaione:masterfrom
sibelius merged 1 commit intochennaione:masterfrom
Conversation
Contributor
|
merged |
Contributor
|
This is not working |
Contributor
|
@firasalkafri could you provide a PR to fix this? |
Contributor
|
@sibeliusseraphini Would definitely do once I get the time...just wanted to share the problem for now in case you have a fix |
Contributor
|
@firasalkafri thanks, try to add a test case that breaks the current version as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked the logic of classpath scanning for entity classes which occurs on database creation or update. I made use of a solution found on SO that can scan all classes in an APK with multi - dex enabled.