Build XCFramework instead of Fat32 binary#30
Merged
Conversation
- Add Temp/ directory to .gitignore to exclude build artifacts - Set SKIP_INSTALL and BUILD_LIBRARY_FOR_DISTRIBUTION flags in build script for iOS Simulator and Device
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the build process by replacing the legacy Fat binary (Fat32) approach with XCFramework, which is Apple's recommended format for distributing binary frameworks. XCFramework supports multiple platforms and architectures without requiring manual lipo operations.
Key Changes:
- Introduced a new build script (
Scripts/build-xcframework.sh) that creates a universal XCFramework supporting both iOS Simulator and Device platforms - Updated CI workflow to use the new XCFramework build process, replacing the previous multi-step Fat binary creation
- Added build artifact directory (
Temp/) to.gitignore
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| Scripts/build-xcframework.sh | New build script that archives for iOS Simulator and Device, then combines them into an XCFramework with comprehensive logging and validation |
| .github/workflows/ci.yml | Replaced legacy Fat binary build steps with single XCFramework build command; updated artifact paths and naming throughout |
| .gitignore | Added Temp/ directory to exclude build artifacts from version control |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a build script to create a universal XCFramework for BEMCheckBox, supporting both iOS Simulator and Device. Update the CI workflow and .gitignore to accommodate build artifacts. Refactor existing build processes for improved clarity and functionality.