Add accessibility support for BEMCheckBox#15
Merged
Conversation
Also fix the failing UI test using the accessibility support to relability find the checkbox.
There was a problem hiding this comment.
Pull Request Overview
This PR adds accessibility support to the BEMCheckBox control and updates the UI testing infrastructure to use more reliable element queries. The changes enhance the checkbox for users with disabilities by providing proper accessibility labels, traits, and values that dynamically update based on the checkbox state.
- Added accessibility properties to BEMCheckBox including label, traits, and dynamic value updates
- Refactored UI tests to use accessibility-based element queries instead of complex navigation hierarchies
- Updated CI workflow to run unit tests during the build process
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Classes/BEMCheckBox.swift | Added accessibility element configuration and dynamic value updates |
| Sample Project/CheckBoxUITests/CheckBoxUITests.m | Simplified element queries using accessibility identifiers |
| .github/workflows/ci.yml | Added unit test execution to CI pipeline |
| CHANGELOG.md | Updated release notes with issue count and formatting changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance BEMCheckBox with accessibility features. Update UI tests to reliably locate the checkbox using accessibility labels. Run the tests during the CI.