feat(shell): auto-cd to newly created worktree after add by satococoa · Pull Request #100 · satococoa/wtp

satococoa · 2026-02-27T15:19:47Z

Summary

extend shell hooks (bash/zsh/fish) to handle wtp add
in interactive TTY sessions, run wtp add ... --quiet and cd to the created path on success
keep non-TTY behavior unchanged (no auto-cd)
update docs and hook tests for add auto-cd behavior

Closes #90

Summary by CodeRabbit

New Features
- Added auto-switching to newly created worktrees when using wtp add -b in interactive shells.
- Clarified that wtp add does not auto-switch directories when stdout is not a TTY.
Documentation
- Updated guides to highlight shell navigation hooks and auto-switching capabilities.
- Added interactive workflow examples demonstrating worktree creation and automatic directory switching.
Tests
- Added test coverage for auto-directory switching after creating worktrees across bash, zsh, and fish shells.

coderabbitai · 2026-02-27T15:19:54Z

Warning

Rate limit exceeded

@satococoa has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 24 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 3eafedd and 2a9c8db.

📒 Files selected for processing (3)

cmd/wtp/completion_config.go
cmd/wtp/hook.go
cmd/wtp/hook_test.go

📝 Walkthrough

Walkthrough

The changes add auto-directory-switching functionality after wtp add in interactive shell environments by implementing add subcommand handling in bash, zsh, and fish hook scripts. When stdout is a TTY, wtp add with --quiet flag returns a target directory, which the shell hook then changes into. Updates include comprehensive test coverage and documentation clarifications regarding shell navigation hooks and TTY behavior.

Changes

Cohort / File(s)	Summary
Hook Script Implementation `cmd/wtp/hook.go`	Added handling for the "add" subcommand across bash, zsh, and fish with logic to detect help flags, check TTY status, invoke `wtp add --quiet` to obtain target directory, and auto-cd on success.
Hook Script Tests `cmd/wtp/hook_test.go`	New test suite `TestHookScripts_AutoCdAfterAdd` validating auto-cd behavior after add action for all three shell variants, checking guard logic, help flag handling, TTY checks, and directory changes.
Help Text and Documentation `cmd/wtp/shell_init.go`, `README.md`, `docs/architecture.md`	Updated command descriptions from "cd functionality" to "shell navigation hooks," added notes on TTY behavior for auto-switching, introduced interactive workflow example with `wtp add -b`, and clarified documentation about auto-directory-switching in TTY sessions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

feat: add --quiet flag for wtp add #99: Implements the --quiet flag that this PR's hook scripts depend on to retrieve the target directory path.
Fix shell hook behavior for "wtp cd" with no args #64: Modifies the same hook generation code and shell hook tests, implementing similar auto-cd logic for the "wtp cd" no-arg case.
Remove auto-cd functionality from wtp add command #18: Related to auto-cd behavior in shell integration; this PR reintroduces auto-cd in hook scripts for wtp add operations.

Poem

A rabbit adds with branch in mind,
One swift command, no pause to find,
The hook springs forth, TTY divine,
The burrow shifts—a new design! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: adding auto-cd functionality when creating a worktree via the add command in shell environments.
Linked Issues check	✅ Passed	The PR implementation directly addresses issue `#90` by extending wtp add to automatically change directory to the newly created worktree in interactive TTY sessions, eliminating the need for separate add and cd commands.
Out of Scope Changes check	✅ Passed	All changes align with the stated objective of implementing auto-cd after wtp add, including hook scripts, tests, documentation updates, and user-facing help text describing the new behavior.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch codex/issue-90-auto-cd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0d0782a6a9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cmd/wtp/hook.go

Copilot

Pull request overview

This PR implements automatic directory switching after successful wtp add commands in interactive TTY sessions, addressing issue #90. The feature extends shell hooks for bash, zsh, and fish to intercept wtp add commands, execute them with the --quiet flag to get clean path output, and automatically cd to the newly created worktree. Non-TTY contexts (pipes, command substitution) maintain standard CLI behavior without auto-switching.

Changes:

Extended shell hooks (bash/zsh/fish) to detect wtp add commands and perform auto-cd in interactive TTY sessions
Updated documentation to explain the new auto-cd behavior and clarify shell integration capabilities
Added unit tests verifying the shell hook scripts contain correct TTY guards, quiet flag usage, and cd logic

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
cmd/wtp/hook.go	Added `wtp add` auto-cd logic to bash, zsh, and fish shell hooks with TTY detection and quiet mode
cmd/wtp/hook_test.go	Added test cases verifying shell hooks generate correct auto-cd patterns for all three shells
cmd/wtp/shell_init.go	Updated command descriptions to reflect expanded shell integration capabilities beyond just cd
docs/architecture.md	Documented that shell hooks now support auto-switching after successful wtp add in interactive sessions
README.md	Added usage example and explanation of auto-cd behavior for wtp add with TTY detection note

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@cmd/wtp/hook.go`:
- Around line 95-107: The wrapper currently returns the original `wtp` exit code
(`status`) even if `cd "$target_dir"` fails, so update the auto-switch flow (the
`elif [[ "$1" == "add" ]]` block and the similar blocks at the other
occurrences) to capture the `cd` command's exit status and return that if
non-zero; specifically, after computing `target_dir` and verifying `$status -eq
0` and `-n "$target_dir"`, run `cd "$target_dir"` and if `cd` fails propagate
its exit code (e.g., assign and return the `cd` exit code) instead of always
returning the original `status`.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 77273d0 and 129b89b.

📒 Files selected for processing (5)

README.md
cmd/wtp/hook.go
cmd/wtp/hook_test.go
cmd/wtp/shell_init.go
docs/architecture.md

cmd/wtp/hook.go

Copilot AI review requested due to automatic review settings February 27, 2026 15:19

Copilot started reviewing on behalf of satococoa February 27, 2026 15:20 View session

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

cmd/wtp/hook.go Show resolved Hide resolved

Copilot AI reviewed Feb 27, 2026

View reviewed changes

feat(shell): auto-cd after successful add in interactive shells

92f7c52

satococoa force-pushed the codex/issue-90-auto-cd branch from 0d0782a to 92f7c52 Compare March 1, 2026 14:21

Base automatically changed from codex/issue-91-add-quiet to main March 1, 2026 15:05

Merge branch 'main' into codex/issue-90-auto-cd

129b89b

coderabbitai bot reviewed Mar 1, 2026

View reviewed changes

cmd/wtp/hook.go Outdated Show resolved Hide resolved

satococoa added 4 commits March 2, 2026 00:22

fix(shell): skip auto-cd for add help invocations

3eafedd

fix(shell): return cd failure status after add

c2ca542

fix: satisfy goconst in completion shell switch

bec8896

fix(shell): harden add hook status handling in zsh/fish

2a9c8db

satococoa merged commit 8e071a2 into main Mar 3, 2026
7 checks passed

satococoa deleted the codex/issue-90-auto-cd branch March 3, 2026 14:38

satococoa mentioned this pull request Mar 3, 2026

[Feature Request] add + cd #90

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(shell): auto-cd to newly created worktree after add#100

feat(shell): auto-cd to newly created worktree after add#100
satococoa merged 6 commits intomainfrom
codex/issue-90-auto-cd

satococoa commented Feb 27, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 27, 2026 •

edited

Loading

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

satococoa commented Feb 27, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

satococoa commented Feb 27, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 27, 2026 •

edited

Loading