Add specs for the support of relative CSS colors#1940
Merged
Conversation
f752f66 to
81bee77
Compare
nex3
reviewed
Sep 27, 2023
Contributor
nex3
left a comment
There was a problem hiding this comment.
Please also add tests for slash lists created with list.slash().
| ================================================================================ | ||
| <===> var/no_alpha/input.scss | ||
| a {b: hsl(from var(--c) h s l)} | ||
| <===> var/no_alpha/output.css |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
looks like the spec linter does not enforce this right now.
Contributor
There was a problem hiding this comment.
The spec linter is unfortunately not as comprehensive as we would like it to be, but it's hard to allocate time to it instead of more pressing concerns.
81bee77 to
37b2758
Compare
Contributor
Author
|
@nex3 I added a test for them for each function. |
nex3
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sass/sass#3673
[skip dart-sass]