Allow specific paths to be passed to js-api-spec#1917
Merged
Conversation
Member
|
Was this not possible before? I recall doing this and it would run only those tests: |
Contributor
Author
|
Nope, currently it's hard-coded. |
Goodwine
approved these changes
Jun 5, 2023
Member
Hm, I wonder why I can filter down to specific test files (not test cases tho) with the pattern I mentioned above 🤔 |
Contributor
Author
|
Are you thinking of the language spec runner? Because I just tried the JS API spec runner on main and it definitely didn't restrict itself to the paths I passed on the CLI. |
Member
|
We figured things out offline, I was in an older version, and I guess a newer version changed things a little so the way I mentioned doesn't work anymore without this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.