Conversation
This was referenced Mar 23, 2023
Goodwine
approved these changes
Mar 23, 2023
| <===> | ||
| ================================================================================ | ||
| <===> pi/math/simplified/input.scss | ||
| a {b: calc(pi * 2)} |
Member
There was a problem hiding this comment.
I wish we had a tau constant 🤣
| a {b: math.div(0px * 0em, 0)} | ||
|
|
||
| <===> error/nan/multiple_numerator_units/error | ||
| Error: calc(NaNpx*em) isn't a valid CSS value. |
Member
There was a problem hiding this comment.
Nit: I think that for NaN and infinity, having the units adjacent to the value makes the error difficult to read for me. I wonder if it would be possible to have a space in between them only for the cases of NaN and infitnity. 🤔
Contributor
Author
There was a problem hiding this comment.
I think a better solution here would be to have a more principled behavior for representing multi-unit values in general using calc, but that's outside the scope of the current change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1885
See sass/sass#3258
[skip dart-sass]