Skip to content

Add Tests for color.is-in-gamut()#1866

Merged
nex3 merged 11 commits intosass:feature.color-4from
oddbird:color-in-gamut
Jan 31, 2023
Merged

Add Tests for color.is-in-gamut()#1866
nex3 merged 11 commits intosass:feature.color-4from
oddbird:color-in-gamut

Conversation

@SondraE
Copy link
Contributor

@SondraE SondraE commented Jan 17, 2023

Part of new/updated tests for color spaces.

See: sass/sass#2831

@SondraE SondraE requested a review from nex3 January 17, 2023 18:29
@nex3
Copy link
Contributor

nex3 commented Jan 18, 2023

I think we should be able to get these tests passing if we merge main into feature.color-4. In future, it's probably a good idea to avoid merging directly from main into one of these PRs, since the feature branch won't always be up-to-date.

@jerivas
Copy link
Contributor

jerivas commented Jan 18, 2023

@nex3 @SondraE I cleaned up the commit history to remove the commits from main. According to my local diffing the end result should be the same as before, let me know if that's not the case

@nex3 nex3 merged commit 8c3ef6f into sass:feature.color-4 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants