add spec for trimming super selectors in @extend#1680
Closed
connorskees wants to merge 1 commit intosass:mainfrom
Closed
add spec for trimming super selectors in @extend#1680connorskees wants to merge 1 commit intosass:mainfrom
@extend#1680connorskees wants to merge 1 commit intosass:mainfrom
Conversation
Member
|
Thanks for this! Can you move this spec to the proper conformant directory? |
Contributor
|
Closing due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a really interesting bug -- the only one I've had to actually clone the
dart-sassrepo for in order to track down. The bug ended up being related to this linehttps://github.com/sass/dart-sass/blob/6f17b4aa9ca879d79d07f83474bae164617570bd/lib/src/extend/extension_store.dart#L135
Set.identityconstructs a set that uses pointer equality, rather than true equality. In rust this is hard to model, so this behavior was overlooked. The fix was implemented by giving a unique id to every original. See connorskees/grass@fccf93cResolves #1678