Conversation
This also cleans up the join specs a bit.
Contributor
Author
|
This shouldn't be submitted until:
|
This was referenced Jun 4, 2019
d8491e2 to
13b483d
Compare
jathak
approved these changes
Jun 11, 2019
| More info and automated migrator: https://sass-lang.com/d/slash-div | ||
|
|
||
| , | ||
| 23 | l: 15 / 5 / $three; |
Member
There was a problem hiding this comment.
Shouldn't there be a warning for the 15 / 5 part of this expression too? (it wouldn't be division on its own, but as part of the larger expression it is)
Contributor
Author
There was a problem hiding this comment.
Good question! Rather than adding another warning, I've updated the recommendation to convert nested divisions to divide() calls as well.
jathak
approved these changes
May 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See sass/sass#2565
[skip dart-sass]