Conversation
Goodwine
requested changes
Apr 23, 2024
| * If `statement` is an `@import` rule, insert a copy of `statement` in `css` | ||
| after the last `@import` rule, or at the beginning of `css` if it doesn't | ||
| contain any `@import` rules. | ||
| * If `statement` is a marked comment, ignore it. |
Member
There was a problem hiding this comment.
I don't see where statement gets marked, I think "them mark it" is missing in the bullet point below 🤔
Contributor
Author
There was a problem hiding this comment.
It's marked on line 210, above.
Member
There was a problem hiding this comment.
That bullet marks a "comment" rather than a statement
Contributor
Author
There was a problem hiding this comment.
Right—this bullet checks if statement is a comment that is marked.
Member
There was a problem hiding this comment.
🤦🏽♂️ for some reason I read this as "If statement is marked, ignore it" lol
Goodwine
approved these changes
Apr 24, 2024
| * If `statement` is an `@import` rule, insert a copy of `statement` in `css` | ||
| after the last `@import` rule, or at the beginning of `css` if it doesn't | ||
| contain any `@import` rules. | ||
| * If `statement` is a marked comment, ignore it. |
Member
There was a problem hiding this comment.
🤦🏽♂️ for some reason I read this as "If statement is marked, ignore it" lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2848