Conversation
stof
reviewed
Apr 19, 2023
stof
reviewed
Apr 20, 2023
|
|
||
| * Let `initial-imports` be the longest initial subsequence of top-level | ||
| statements in `domestic`'s CSS tree that contains only comments and | ||
| `@import` rules *and* that ends with an `@import` rule. |
Contributor
There was a problem hiding this comment.
Given that we take the long initial subsequence of comments and @import rules in css in the next step when looking for the insertion point, should we enforce ending with an @import here ?
Contributor
Author
There was a problem hiding this comment.
I think we should put this below comments, because otherwise if the entrypoint file contains no @imports they'll end up going before everything in that file, including potentially a license comment, which wouldn't be ideal.
3 tasks
jathak
approved these changes
Apr 25, 2023
Co-authored-by: Jennifer Thakar <jathak@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2848