Conversation
5 tasks
Goodwine
approved these changes
Dec 15, 2025
| return 'a98rgb'; | ||
| case 'display-p3': | ||
| return 'p3'; | ||
| case 'display-p3-linear': |
Member
There was a problem hiding this comment.
Nit: Do we have exhaustive checks enabled in eslint?
It doesn't seem like we do so explicitly, it's not enabled by default by eslint, and I couldn't tell whether gts enabled it 🤔
If not, it may be a good idea to do so, or at the very least to have a const _never: never = value in a default case for the compiler to warn about it.
Contributor
Author
There was a problem hiding this comment.
Looks like we do have them enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See sass/sass#4167
See sass/sass-spec#2095
See sass/dart-sass#2703