Conversation
This also stops running shell commands silently to help diagnose errors, and ensures that the embedded protocol's VERSION file is accessible even when installing from a path.
Merge main into feature.color-4
Merge branch 'main' of github.com:sass/embedded-host-node into feature.color-4
Merge main into feature.color-4
Merge main into feature.color-4
Merge main into feature.color-4
Merge origin/main into feature.color-4
Merge main into feature.color-4
Merge origin/main into feature.color-4
13 tasks
jathak
requested changes
Sep 13, 2024
| } | ||
|
|
||
| /** Warn users about legacy color channel getters. */ | ||
| function emitColor4ApiGetterDeprecation(name: string): void { |
Member
There was a problem hiding this comment.
All of the color-4-api deprecation warnings need some sort of handling for silenceDeprecations and fatalDeprecations since the host can't rely on the compiler to do the processing for any warnings emitted directly by the host.
Contributor
Author
There was a problem hiding this comment.
I think it might be worth just merging this anyway so that we can get rid of the feature branch hassle, and then updating this along with your incoming change.
jathak
approved these changes
Sep 13, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #170
See sass/sass#3930
See sass/sass-spec#2013
See sass/dart-sass#2341