Fix race condition in SyncMessagePort#327
Merged
Conversation
ntkme
commented
Aug 28, 2024
nex3
requested changes
Aug 30, 2024
Contributor
nex3
left a comment
There was a problem hiding this comment.
Would it be possible to add a more direct test case for this to sync-message-port.test.ts? Or is the existing flaky failure the best we can do to exercise it?
Contributor
Author
I've added a test as it turns out it is much more easier to reproduce it with a test case. On my local setup, the added test case 100% fails on main branch without adjusting timing artificially. |
Co-authored-by: Natalie Weizenbaum <nweiz@google.com>
nex3
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #326.
The idea of this PR is that instead of having only three states:
This PR uses four states:
This allows
receiveMessage()to correctly consume the very last message.