Skip to content

Workaround for shelljs in windows to fix CI#236

Merged
Goodwine merged 2 commits intomainfrom
fix-windows-ci-shelljs
Jul 1, 2023
Merged

Workaround for shelljs in windows to fix CI#236
Goodwine merged 2 commits intomainfrom
fix-windows-ci-shelljs

Conversation

@Goodwine
Copy link
Member

@Goodwine Goodwine commented Jun 29, 2023

shell.cp() creates invalid symlinks when copying directories in Windows.
See: shelljs/shelljs#198

@Goodwine Goodwine force-pushed the fix-windows-ci-shelljs branch 2 times, most recently from 9f651d9 to f94da50 Compare June 29, 2023 23:01
@Goodwine Goodwine changed the title test https://github.com/shelljs/shelljs/issues/198 Jun 29, 2023
@Goodwine Goodwine changed the title https://github.com/shelljs/shelljs/issues/198 Workaround shelljs in windows to fix CI Jun 29, 2023
@Goodwine Goodwine changed the title Workaround shelljs in windows to fix CI Workaround for shelljs in windows to fix CI Jun 29, 2023
@Goodwine Goodwine force-pushed the fix-windows-ci-shelljs branch from f94da50 to e452e73 Compare June 29, 2023 23:09
shell.cp() creates invalid symlinks when copying directories
See: shelljs/shelljs#198
@Goodwine Goodwine force-pushed the fix-windows-ci-shelljs branch from e452e73 to c1c7a78 Compare June 29, 2023 23:12
@Goodwine Goodwine marked this pull request as ready for review June 29, 2023 23:12
@Goodwine Goodwine requested a review from nex3 June 29, 2023 23:12
@Goodwine Goodwine force-pushed the fix-windows-ci-shelljs branch from f645cb9 to d79ecb0 Compare June 30, 2023 22:01
@Goodwine Goodwine force-pushed the fix-windows-ci-shelljs branch from d79ecb0 to a09841e Compare June 30, 2023 23:08
@Goodwine Goodwine merged commit c73d448 into main Jul 1, 2023
@Goodwine Goodwine deleted the fix-windows-ci-shelljs branch July 1, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants