Skip to content

Fallback values for empty defaults#63

Merged
sarnold merged 2 commits intomasterfrom
fallback-for-defaults
Aug 10, 2025
Merged

Fallback values for empty defaults#63
sarnold merged 2 commits intomasterfrom
fallback-for-defaults

Conversation

@sarnold
Copy link
Copy Markdown
Owner

@sarnold sarnold commented Aug 9, 2025

  • add fallback values for empty environment settings
  • provide the same default values for each setting var if set but empty
  • add another test using monkeypatched empty values
  • update requirements file and coverage config

this closes issue #62

github-actions[bot]
github-actions bot previously approved these changes Aug 9, 2025
sarnold added 2 commits August 9, 2025 14:05
* provide the same default values for each setting var if set but empty
* add another test using monkeypatched empty values
* update requirements file and coverage config

this closes issue #62

Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 9, 2025

Package Line Rate Branch Rate Complexity Health
src.pyserv 96% 96% 0
Summary 96% (211 / 219) 96% (27 / 28) 0

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 9, 2025

Hello @sarnold! Thanks for opening this PR. We found the following information based on analysis of the coverage report:

Base Branch Rate coverage is 90%
Merging 9787e60 into master will increase coverage by 6%

Nice work, @sarnold. Cheers! 🍻

@sarnold sarnold added bug Something isn't working documentation Improvements or additions to documentation labels Aug 9, 2025
@sarnold sarnold merged commit 640c42b into master Aug 10, 2025
55 checks passed
@sarnold sarnold deleted the fallback-for-defaults branch August 10, 2025 00:39
@sarnold sarnold linked an issue Aug 10, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEBUG set to empty string causes crash

1 participant