apps/hotelmanagement/src/app/dashboard/property.spec.ts (1)

13-15: Add a behavior test for getHotels() output.

This currently checks only instantiation. Please also assert the returned hotels shape/count so service behavior is covered.

✅ Suggested test addition

 describe('PropertyService', () => {
@@
   it('should be created', () => {
     expect(service).toBeTruthy();
   });
+
+  it('should return the seeded hotels list', () => {
+    const hotels = service.getHotels()();
+    expect(hotels.length).toBe(3);
+    expect(hotels[0].name).toBe('Hotel California');
+  });
 });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/hotelmanagement/src/app/dashboard/property.spec.ts` around lines 13 -
15, Add a unit test in property.spec.ts that calls the service.getHotels()
method and asserts the returned value shape and count: invoke getHotels() (or
getHotels().subscribe if it returns an Observable) on the existing service
instance, then expect the result to be an array of hotel objects with the
expected length and required properties (e.g., id, name, address). Make the test
use the same setup/DI as the existing "should be created" spec and mock any
dependencies or provide fake data as needed so the assertion verifies both shape
(keys) and count.

apps/hotelmanagement/src/app/dashboard/property.ts (2)

10-12: Remove constructor console logging in service initialization.

Line 11 logs on every service creation and can add noise in production/test output.

🧹 Proposed cleanup

-  constructor() {
-    console.log('PropertyService initialized');
-  }
+  constructor() {}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/hotelmanagement/src/app/dashboard/property.ts` around lines 10 - 12, The
PropertyService constructor currently contains a console.log('PropertyService
initialized') that should be removed to avoid noisy output; edit the constructor
in the PropertyService class (the constructor method shown in the diff) to
delete the console.log call and, if initialization telemetry is required,
replace it with the project's structured logger (e.g., use the shared logger
instance or a debug-level logger) rather than console.log.

---

8-37: Make getHotels() read-only and side-effect free.

The method currently mutates state on every read (line 16: this.hotels.set()), and returning the writable signal exposes write access that external code could exploit. Initialize the data once and return a readonly signal via asReadonly() to prevent mutations and side effects.

♻️ Proposed refactor

-import { Injectable, signal } from '@angular/core';
+import { Injectable, Signal, signal } from '@angular/core';
 import { IHotel } from './Hotel';
@@
 export class PropertyService {
-  hotels = signal<IHotel[]>([]);
+  private readonly hotels = signal<IHotel[]>([
+    {
+      id: 1,
+      name: 'Hotel California',
+      location: 'Los Angeles',
+      numberOfRooms: 0,
+    },
+    {
+      id: 2,
+      name: 'The Grand Budapest Hotel',
+      location: 'Zubrowka',
+      numberOfRooms: 200,
+    },
+    {
+      id: 3,
+      name: 'The Overlook Hotel',
+      location: 'Colorado',
+      numberOfRooms: 10,
+    },
+  ]);
@@
-  getHotels() {
-    // This method would typically make an HTTP request to fetch hotel data
-    this.hotels.set([
-      {
-        id: 1,
-        name: 'Hotel California',
-        location: 'Los Angeles',
-        numberOfRooms: 0,
-      },
-      {
-        id: 2,
-        name: 'The Grand Budapest Hotel',
-        location: 'Zubrowka',
-        numberOfRooms: 200,
-      },
-      {
-        id: 3,
-        name: 'The Overlook Hotel',
-        location: 'Colorado',
-        numberOfRooms: 10,
-      },
-    ]);
-    return this.hotels;
+  getHotels(): Signal<IHotel[]> {
+    return this.hotels.asReadonly();
   }
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/hotelmanagement/src/app/dashboard/property.ts` around lines 8 - 37, The
getHotels method currently mutates the hotels signal on every call and returns a
writable signal; change this by initializing the hotel array only once (either
as the initial value when creating hotels = signal<IHotel[]>([...]) or by
setting it in the constructor) and make getHotels return a readonly view using
this.hotels.asReadonly() (remove the this.hotels.set(...) from getHotels so it
becomes side-effect free and only exposes the readonly signal). Ensure
references to hotels, getHotels, constructor, and asReadonly() are updated
accordingly.