apps/hotelmanagement/src/app/dashboard/dashboard.html (2)

18-24: Remove stale commented-out code.

The legacy *ngFor block references hotels (should be hotelList), and hotel.image/hotel.description which don't exist on the Hotel interface. It also uses the old structural directive syntax that has been superseded. Clean this up before merging.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/hotelmanagement/src/app/dashboard/dashboard.html` around lines 18 - 24,
Delete the stale commented-out block that contains the legacy *ngFor and
references to hotels, hotel.image and hotel.description; remove the entire
commented HTML snippet (do not attempt to resurrect it), and if the UI should
display a list ensure you implement or reference the current property name
hotelList and fields defined on the Hotel interface elsewhere instead of reusing
the old names.

---

5-16: Simplify with @for's built-in @empty block.

The outer @if guard is redundant — Angular's @for block directly supports an @empty section that is displayed when the collection is empty. Replace the @if + @for + @else combination with a single @for + @empty:

♻️ Proposed refactor

-@if (hotelList.length > 0) { `@for` (hotel of hotelList; track $index) {
+@for (hotel of hotelList; track $index) {
 <div class="hotel">
   ID:
   <p>{{$index + 1}}</p>
   Name:
   <h4>{{hotel.name}}</h4>
   Location:
   <p>{{hotel.location}}</p>
 </div>
-} } `@else` {
+} `@empty` {
 <h4>No hotels available.</h4>
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/hotelmanagement/src/app/dashboard/dashboard.html` around lines 5 - 16,
Remove the redundant outer `@if` check and convert the current `@for/`@else pattern
into a single `@for` block that uses `@empty`; specifically, replace the surrounding
"@if (hotelList.length > 0) { `@for` (hotel of hotelList; track $index) { ... } }
`@else` { <h4>No hotels available.</h4> }" with "@for (hotel of hotelList; track
$index) { ... } `@empty` { <h4>No hotels available.</h4> }", keeping the existing
template content that references hotel and $index unchanged.

apps/hotelmanagement/src/app/dashboard/dashboard.spec.ts (1)

13-16: Add fixture.detectChanges() before whenStable().

Without an explicit fixture.detectChanges() call, Angular's initial change detection cycle never runs — component template bindings are not evaluated and lifecycle hooks like ngOnInit are not triggered. whenStable() alone does not kick off change detection.

♻️ Proposed fix

 fixture = TestBed.createComponent(Dashboard);
 component = fixture.componentInstance;
+fixture.detectChanges();
 await fixture.whenStable();

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/hotelmanagement/src/app/dashboard/dashboard.spec.ts` around lines 13 -
16, The test creates the component with TestBed.createComponent(Dashboard) but
never runs Angular's initial change detection; add an explicit
fixture.detectChanges() call immediately after creating the component (before
await fixture.whenStable()) so bindings and lifecycle hooks (e.g., ngOnInit)
execute; update the block around TestBed.createComponent(Dashboard), component =
fixture.componentInstance to call fixture.detectChanges() prior to awaiting
fixture.whenStable().

apps/hotelmanagement/src/app/dashboard/dashboard.ts (1)

16-23: numberOfBookings and dateOfLastBooking are declared but never rendered.

Both properties are initialised on the component but absent from dashboard.html. If they are intended as future placeholders, a short // TODO comment would clarify intent; otherwise consider removing them to avoid dead surface area.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/hotelmanagement/src/app/dashboard/dashboard.ts` around lines 16 - 23,
The properties numberOfBookings and dateOfLastBooking on the Dashboard component
are defined but never used in the template; either remove them to eliminate dead
surface area or make their intent explicit and/or render them: if they are
placeholders add a short TODO comment above each field in dashboard.ts
referencing numberOfBookings and dateOfLastBooking, otherwise remove the unused
fields, or update dashboard.html to display them (bind the values or
conditionally show dateOfLastBooking) so the component fields are actually
consumed.

apps/hotelmanagement/src/app/app.ts (1)

2-6: RouterModule is now unused.

app.html only renders <hm-dashboard> — there is no <router-outlet> or routerLink in the template, so RouterModule contributes nothing and can be dropped from both the import statement and the imports array.

♻️ Proposed fix

 import { Component } from '@angular/core';
-import { RouterModule } from '@angular/router';
 import { Dashboard } from './dashboard/dashboard';

 `@Component`({
-  imports: [ RouterModule, Dashboard],
+  imports: [Dashboard],
   selector: 'hm-root',
   templateUrl: './app.html',
   styleUrl: './app.css',
 })

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/hotelmanagement/src/app/app.ts` around lines 2 - 6, Remove the unused
RouterModule import and its reference in the component metadata: delete the
RouterModule import line and remove RouterModule from the `@Component`({ imports:
[...] }) array (leave Dashboard in imports); verify app.html renders
<hm-dashboard> and no router-outlet/routerLink exists so RouterModule is
unnecessary.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro