Handle space characters in fontFamily within TTML Parsing #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mattjuggins Ready for review? |
Contributor
Author
|
@palemieux yep, all ready. I don't believe there's anything more to it. |
palemieux
requested changes
Dec 21, 2023
| <body> | ||
| <div> | ||
| <p tts:fontFamily="default">Maps 'default' generic family name to 'monospaceSerif' correctly.</p> | ||
| <p tts:fontFamily="Arial,default">Maps 'default' value used as a fallback to 'monospaceSerif' correctly.</p> |
Contributor
There was a problem hiding this comment.
Please align the <p> elements
Contributor
|
@mattjuggins Looks great. Just one minor nit to fix if you do not mind. |
Contributor
Author
|
@palemieux no problem. That should be sorted now. |
palemieux
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #250
Similar to #245, the
defaultgeneric font family was not being correctly mapped tomonospaceSerifif there were stray spacing characters on either side of the word, i.e.default.A solution similar to #246 is implemented using
trim()and a unit test is provided for sanity checking.