Apply tts:fontFamily, tts:fontWeight, tts:fontStyle and tts:fontSize to p #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@nigelmegitt Please review |
nigelmegitt
approved these changes
Feb 3, 2021
Contributor
nigelmegitt
left a comment
There was a problem hiding this comment.
This is good for fixing #201. I see that the fix for w3c/ttml2#1215 also applies tts:fontWeight and tts:fontStyle to p. Would it be worth adding those into this PR too?
(for the eagle-eyed, yes, w3c/ttml2#1215 does add tts:fontSelectionStrategy and tts:fontVariant but they're not permitted in IMSC)
Contributor
Author
|
@nigelmegitt See 60dd822 |
nigelmegitt
approved these changes
Feb 3, 2021
Contributor
nigelmegitt
left a comment
There was a problem hiding this comment.
Thanks @palemieux looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #201