Fix textAlign flow relative polyfill #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cconcolato
reviewed
Jun 1, 2020
|
|
||
| var pdir = isd_element.styleAttrs[imscStyles.byName.direction.qname]; | ||
|
|
||
| context.ipd = pdir === "ltr" ? "lr" : "rl"; |
There was a problem hiding this comment.
I'm not sure I understand why this change is necessary. Can you create an example?
Contributor
Author
There was a problem hiding this comment.
@cconcolato Even though it is not entirely clear in TTML2, tts:direction, when specified on p, is intended to override tts:writingMode (at least when ipd is horizontal), otherwise the following test does not work: https://github.com/w3c/imsc-tests/blob/master/imsc1/ttml/direction/Direction003.ttml . It is not clear what is the intended effect of tts:direction specified on p when the ipd is vertical -- in the case of CSS, this overrides the ipd vertically, where ltr means tb and rtl means bt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #177