Skip to content

For .. in loops not protected from iterating prototype properties #209

@xoundboy

Description

@xoundboy

I've been testing the library on Samsung and WebOS tvs and discovered that on one 2020 Samsung device execution breaks inside several of the for.. in loops conained in this library due to native prototype properties being iterated as regular array members. I don't know yet exactly why the problem only appears on this TV, however I was easily able to fix it using the hasOwnProperty check. I'm wondering whether I can submit a PR for this change to be merged to master? I have it ready to push. There are quite a few places the check is needed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions