✨ feat(formatter): add diff truncator and enhance formatting with Dif…#43
✨ feat(formatter): add diff truncator and enhance formatting with Dif…#43
Conversation
…fStatsSeparator constant and emoji prefix type inference Signed-off-by: samzong <samzong.lu@gmail.com>
Summary of ChangesHello @samzong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the commit message formatting capabilities by introducing a smart diff truncation system. This system intelligently reduces the size of large diffs presented to the user, focusing on retaining critical changes while omitting less important ones. Additionally, it refines the process of automatically determining commit types from emoji prefixes, leading to more accurate and standardized commit messages. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces significant enhancements to diff formatting and commit message generation. The new diff truncator intelligently prioritizes changes, ensuring that the most relevant information is presented within a given limit. Additionally, the system can now infer commit types from emoji prefixes, improving the flexibility and user experience of commit message formatting. The changes are well-integrated across internal/emoji, internal/formatter, internal/git, and internal/workflow modules, with corresponding test updates.
| if strings.Contains(path, "{") && strings.Contains(path, "}") { | ||
| oldPath := "" | ||
| newPath := "" | ||
| rest := path | ||
| for { | ||
| start := strings.Index(rest, "{") | ||
| end := strings.Index(rest, "}") | ||
| if start == -1 || end == -1 || end < start { | ||
| oldPath += rest | ||
| newPath += rest | ||
| break | ||
| } | ||
| oldPath += rest[:start] | ||
| newPath += rest[:start] | ||
| segment := rest[start+1 : end] | ||
| parts := strings.SplitN(segment, "=>", 2) | ||
| if len(parts) != 2 { | ||
| oldPath += "{" + segment + "}" | ||
| newPath += "{" + segment + "}" | ||
| } else { | ||
| oldPath += strings.TrimSpace(parts[0]) | ||
| newPath += strings.TrimSpace(parts[1]) | ||
| } | ||
| rest = rest[end+1:] | ||
| } |
There was a problem hiding this comment.
The splitRenamePath function, particularly the logic for handling {old => new} syntax, is quite complex and involves multiple string manipulations and conditional checks. While it appears to cover the intended cases, such intricate parsing logic can be brittle and prone to edge-case bugs. Consider adding more dedicated unit tests for this function with various rename path formats (e.g., paths with multiple {} blocks, nested {} blocks, or malformed {} blocks) to ensure its robustness and correctness.
…fStatsSeparator constant and emoji prefix type inference