Improve plot-bamstats qual-hm#2143
Merged
Merged
Conversation
Fixes warning "warning: y2 axis range undefined or overflow, resetting to [0:0]" which resulted in missing y-ticks. Fixed quals-hm layout to be 2 distinct plots. Adjusts the colour of the heatmap to be easier to read, avoiding multiple dark zones in the colour wheel. Fixes broken links in the HTML table for characters that need URI escaping. Reduce width of plot so that "Number of bases" heatmap label is not clipped
whitwham
reviewed
Dec 3, 2024
| $args = get_defaults($opts,"$$opts{prefix}quals2.png",wh=>$is_paired ? '700,500' : '600,400'); | ||
| $fh = $$args{fh}; | ||
| my $pos_size = $is_paired ? " set rmargin 0; set lmargin 0; set tmargin 0; set bmargin 0; set origin 0.1,0.1; set size 0.4,0.8" : ''; | ||
| # my $pos_size = $is_paired ? " set rmargin 0; set lmargin 0; set tmargin 0; set bmargin 0; set origin 0.1,0.1; set size 0.4,0.8" : ''; |
Member
There was a problem hiding this comment.
Does this line still need to be in here?
Fix single-ended run plots. Reduce rate of tick labels for long-reads. Adjust colour wheel to bring out more fidelity with very low qualities so we have better distinction between all zero and some low qual. Replaces / fixes samtools#2116
1d89c57 to
f0964c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This combines @jgrg's #2116 with my own additions to cope with long-read technologies and to fix a bug introduced with single end libraries.
Before and after screenshots for the combined commits.
Novaseq
Revio
Ultima